fix nondeterminism in OptionalMethodCallProcessor

src/Generator/Caller/Chainable/OptionalMethodCallProcessor.php

@@ -13,6 +13,7 @@
 
 namespace Nelmio\Alice\Generator\Caller\Chainable;
 
+use Faker\Generator as FakerGenerator;
 use LogicException;
 use Nelmio\Alice\Definition\MethodCall\OptionalMethodCall;
 use Nelmio\Alice\Definition\MethodCallInterface;
@@ -33,14 +34,20 @@ final class OptionalMethodCallProcessor implements ChainableCallProcessorInterfa
      */
     private $processor;
 
-    public function __construct(?CallProcessorInterface $processor = null)
+    /**
+     * @var ?FakerGenerator
+     */
+    private $faker;
+
+    public function __construct(?CallProcessorInterface $processor = null, ?FakerGenerator $faker = null)
     {
         $this->processor = $processor;
+        $this->faker = $faker;
     }
 
     public function withProcessor(CallProcessorInterface $processor): self
     {
-        return new self($processor);
+        return new self($processor, $this->faker);
     }
 
     public function canProcess(MethodCallInterface $methodCall): bool
@@ -65,7 +72,13 @@ public function process(
             throw new LogicException('TODO');
         }
 
-        if (random_int(0, 99) >= $methodCall->getPercentage()) {
+        // TODO: for BC purposes, let's fallback to random_int. The generator should be made
+        //   non-nullable in 4.x and the random_int usage removed. (See OptionalValueResolver)
+        $random = null !== $this->faker
+            ? $this->faker->numberBetween(0, 99)
+            : random_int(0, 99);
+
+        if ($random >= $methodCall->getPercentage()) {
             return $fixtureSet;
         }
 

src/Loader/NativeLoader.php

@@ -633,7 +633,7 @@ protected function createCallProcessor(): CallProcessorInterface
         return new CallProcessorRegistry([
             new ConfiguratorMethodCallProcessor(),
             new MethodCallWithReferenceProcessor(),
-            new OptionalMethodCallProcessor(),
+            new OptionalMethodCallProcessor(null, $this->getFakerGenerator()),
             new SimpleMethodCallProcessor(),
         ]);
     }

tests/Loader/LoaderIntegrationTest.php

@@ -37,6 +37,7 @@
 use Nelmio\Alice\UserDetail;
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
+use ReflectionObject;
 use stdClass;
 use Throwable;
 use TypeError;
@@ -1575,6 +1576,33 @@ public function testNewlinesInIdentity(): void
         );
     }
 
+    public function testOptionalMethodCallsAreDeterministic(): void
+    {
+        $gen_sequence = function (NativeLoader $loader) {
+            $set = $loader->loadData([
+                FixtureEntity\Caller\Dummy::class => [
+                    'dummy{0..9}' => [
+                        '__construct' => false,
+                        '__calls' => [
+                            ['setTitle (50%?)' => ['Foo']],
+                        ],
+                    ],
+                ],
+            ]);
+            $objs = array_values($set->getObjects());
+
+            return array_map(
+                fn ($obj) => (new ReflectionObject($obj))->getProperty('title')->getValue($obj),
+                $objs,
+            );
+        };
+
+        $seq_1 = $gen_sequence(new NativeLoader());
+        $seq_2 = $gen_sequence(new NativeLoader());
+
+        self::assertSame($seq_1, $seq_2);
+    }
+
     public static function provideFixturesToInstantiate(): iterable
     {
         yield 'with default constructor – use default constructor' => [