TASK: Adjust dataProviders to be static, other fixes

neos · Dec 9, 2024 · 8435768 · 8435768
1 parent 8fc4ebf
commit 8435768
Show file tree

Hide file tree

Showing 40 changed files with 954 additions and 819 deletions.
diff --git a/Neos.Cache/Tests/Unit/Backend/FileBackendEntryDtoTest.php b/Neos.Cache/Tests/Unit/Backend/FileBackendEntryDtoTest.php
@@ -13,7 +13,7 @@ class FileBackendEntryDtoTest extends BaseTestCase
 {
     /**
      */
-    public function validEntryConstructorParameters()
+    public static function validEntryConstructorParameters(): array
     {
         return [
             ['data', [], 0],
@@ -29,13 +29,8 @@ public function validEntryConstructorParameters()
     /**
      * @dataProvider validEntryConstructorParameters
      * @test
-     *
-     * @param string $data
-     * @param array $tags
-     * @param int $expiryTime
-     * @return void
      */
-    public function canBeCreatedWithConstructor($data, $tags, $expiryTime)
+    public function canBeCreatedWithConstructor(string $data, array $tags, int $expiryTime): void
     {
         $entryDto = new FileBackendEntryDto($data, $tags, $expiryTime);
         self::assertInstanceOf(FileBackendEntryDto::class, $entryDto);
@@ -44,13 +39,8 @@ public function canBeCreatedWithConstructor($data, $tags, $expiryTime)
     /**
      * @dataProvider validEntryConstructorParameters
      * @test
-     *
-     * @param $data
-     * @param $tags
-     * @param $expiryTime
-     * @return void
      */
-    public function gettersReturnDataProvidedToConstructor($data, $tags, $expiryTime)
+    public function gettersReturnDataProvidedToConstructor(string $data, array $tags, int $expiryTime): void
     {
         $entryDto = new FileBackendEntryDto($data, $tags, $expiryTime);
         self::assertEquals($data, $entryDto->getData());
@@ -60,19 +50,17 @@ public function gettersReturnDataProvidedToConstructor($data, $tags, $expiryTime
 
     /**
      * @test
-     * @return void
      */
-    public function isExpiredReturnsFalseIfExpiryTimeIsInFuture()
+    public function isExpiredReturnsFalseIfExpiryTimeIsInFuture(): void
     {
         $entryDto = new FileBackendEntryDto('data', [], time() + 10);
         self::assertFalse($entryDto->isExpired());
     }
 
     /**
      * @test
-     * @return void
      */
-    public function isExpiredReturnsTrueIfExpiryTimeIsInPast()
+    public function isExpiredReturnsTrueIfExpiryTimeIsInPast(): void
     {
         $entryDto = new FileBackendEntryDto('data', [], time() - 10);
         self::assertTrue($entryDto->isExpired());
@@ -81,9 +69,8 @@ public function isExpiredReturnsTrueIfExpiryTimeIsInPast()
     /**
      * @dataProvider validEntryConstructorParameters
      * @test
-     * @return void
      */
-    public function isIdempotent($data, $tags, $expiryTime)
+    public function isIdempotent(string $data, array $tags, int $expiryTime): void
     {
         $entryDto = new FileBackendEntryDto($data, $tags, $expiryTime);
         $entryString = (string)$entryDto;