-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Fix cache RedisBackend unittest #3194
Merged
kdambekalns
merged 2 commits into
neos:8.0
from
kdambekalns:task/fix-cache-redisbackend-unittest
Oct 12, 2023
Merged
TASK: Fix cache RedisBackend unittest #3194
kdambekalns
merged 2 commits into
neos:8.0
from
kdambekalns:task/fix-cache-redisbackend-unittest
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
The "lowest dependencies" build fails, since PhpUnit only since 9.6 copes with return types like |
kdambekalns
added a commit
to kdambekalns/flow-development-distribution
that referenced
this pull request
Oct 11, 2023
kdambekalns
added a commit
to kdambekalns/flow-development-distribution
that referenced
this pull request
Oct 11, 2023
See neos/flow-development-collection#3194 (comment) # Conflicts: # composer.json
ahaeslich
approved these changes
Oct 11, 2023
mhsdesign
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thänks ;)
Oh no, it seems this affects 7.3, too… 😵💫 -> let's try #3196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test failed due to a missing return value from a method not being mocked (correctly),
Checklist
FEATURE|TASK|BUGFIX
Reviewer - Breaking Changes are marked wit!!!
and have upgrade-instructions