Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Fix cache RedisBackend unittest #3194

Merged

Conversation

kdambekalns
Copy link
Member

A test failed due to a missing return value from a method not being mocked (correctly),

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest affected branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

@kdambekalns
Copy link
Member Author

kdambekalns commented Oct 11, 2023

The "lowest dependencies" build fails, since PhpUnit only since 9.6 copes with return types like string|bool… but we have ~9.1 in the Flow development distributions' composer manifest.

-> neos/flow-development-distribution#84

kdambekalns added a commit to kdambekalns/flow-development-distribution that referenced this pull request Oct 11, 2023
kdambekalns added a commit to kdambekalns/flow-development-distribution that referenced this pull request Oct 11, 2023
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thänks ;)

@kdambekalns kdambekalns merged commit 4ddecd7 into neos:8.0 Oct 12, 2023
6 of 7 checks passed
@kdambekalns kdambekalns deleted the task/fix-cache-redisbackend-unittest branch October 12, 2023 08:16
@kdambekalns
Copy link
Member Author

kdambekalns commented Oct 12, 2023

Oh no, it seems this affects 7.3, too… 😵‍💫

-> let's try #3196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants