-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Migrate to PHPStan (adjustments in Flow 9) #3216
Conversation
645fb8f
to
c5ff30e
Compare
Mmm, but like in 9.0? I think this will make upmerges harder than they already are with the many chnages in this major version, I would rather do it in 8.0 maybe? In the hopes that we don't upmerge 7.3 all that much anymore... |
Draft as we probably want to target 8.0 #3218 Things that are not included there: Adding |
61e68f7
to
fe8df10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think. But I'd like to see the deprecation removals in their own commit, at least. Otherwise they are camouflaged a bit too much…
With #3218 PHPStan level 1 was added to the whole Flow code base and CI for Flow 8. This upmerged change needs some adjustments to pass the CI in Flow 9 - fix types and remove deprecated code - fix types where neos depends on it (by correcting types and adding `never`) - adjust unit test as `never` cannot be doubled (eventually this will be fixed via: sebastianbergmann/phpunit#5048) - fix ci and style as neos 9 followup for #3218
fe8df10
to
162cc34
Compare
With #3218 PHPStan level 1 was added to the whole Flow code base and CI for Flow 8. This upmerged change needs some adjustments to pass the CI in Flow 9
never
)never
cannot be doubled (eventually this will be fixed via: Methods that returnnever
cannot be doubled sebastianbergmann/phpunit#5048)Checklist
The PR is created against the lowest maintained branchFEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions