TASK: WorkspaceWasPublished
implement EmbedsWorkspaceName
#5431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5226 introduced a new
EmbedsWorkspaceName
interface for events but its not implemented by theWorkspaceWasPublished
but all other publishing events. This pr fixes this inconsistency.It was noted in #5406 (comment) that the introduction was deliberately not done because there is a certain ambiguity regarding returning "$sourceWorkspaceName" or "$targetWorkspaceName". Further we currently rely on
WorkspaceWasPublished
implementing this interface currently.Still i wanted to elaborate why i think its correct and that its a good idea to have it:
There is another related inconsistency regarding the
RootWorkspaceWasCreated
event: #5226 (comment) so it seems not always easy to mark the events correctly.