Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in function name when called #30

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

dbarbuzzi
Copy link
Contributor

Summary:

Fixes a bug in actions/testmo-run-submit-thread/action.yml where the step_status function defined was being called by the wrong name later.

Test Plan:

Related logic tested independently with an action that runs the problem area using Bash script:

step_status() {
  # echo "green encased checkmark" if "${1} == 0"
  # echo "red X"                   if "${1} != 0"

  if [ "$1" -eq 0 ]; then
    # green check
    echo -e "\xE2\x9C\x85"
  else
    # red x
    echo -e "\xE2\x9D\x8C"
  fi
}

step_status 0
step_status 1
step_status -12

Output:

✅
❌
❌

@dbarbuzzi dbarbuzzi requested a review from dhuangnm September 24, 2024 14:11
@dbarbuzzi dbarbuzzi self-assigned this Sep 24, 2024
@dbarbuzzi dbarbuzzi added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 226cf71 Sep 24, 2024
1 check passed
@dbarbuzzi dbarbuzzi deleted the fix-testmo-submit-thread branch September 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants