Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Testmo actions self-contained #41

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

dbarbuzzi
Copy link
Contributor

Summary:

Make the Testmo actions self-contained so that consuming workflows don’t need to worry about installing any dependencies.

Details:

Each of the Testmo usage actions now call the install-testmo action first, ensuring the action’s dependencies are installed.

Also, the install-testmo action itself is updated with some checks so that Node.js and the Testmo CLI tool are only installed if not already available.

The one caveat is that they are all currently set to use the (next) version tag from this repo, 1.10.0. So long as the tag is created shortly after this PR is merged, this is negligible (and wouldn’t affect any existing repos, as they would be using the older version tag for these actions).

Test Plan:

This run (which expectedly failed with invalid inputs/credentials) shows this change working in the testmo-run-create action (it only uses that one action after checkout): https://github.com/neuralmagic/nm-actions/actions/runs/12301377628/job/34331825686

  • If you review the output in the Run neuralmagic/nm-actions/actions/testmo-run-create@self-contained-testmo-actions-test step, you can see Node.js/Testmo CLI tool being checked for and installed
  • Further down the output toward the end, the message "Project ID needs to be a positive number" is actually from the Testmo CLI tool itself, proving that it was installed successfully in order to be able to generate that message

@dbarbuzzi dbarbuzzi self-assigned this Dec 12, 2024
Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dbarbuzzi dbarbuzzi added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit ce61432 Dec 12, 2024
1 check passed
@dbarbuzzi dbarbuzzi deleted the self-contained-testmo-actions branch December 12, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants