-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for nvenc and accel_assist #3320
Open
jsorg71
wants to merge
2
commits into
neutrinolabs:devel
Choose a base branch
from
jsorg71:nvenc
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
AM_CPPFLAGS = \ | ||
-I$(top_srcdir)/common | ||
|
||
EXTRA_DIST = xrdp_accel_assist_shaders.c | ||
|
||
XRDP_EXTRA_LIBS = | ||
XRDP_EXTRA_SOURCES = | ||
|
||
if XRDP_NVENC | ||
AM_CPPFLAGS += -DXRDP_NVENC | ||
AM_CPPFLAGS += $(XRDP_NVENC_CFLAGS) | ||
XRDP_EXTRA_LIBS += $(XRDP_NVENC_LIBS) | ||
XRDP_EXTRA_SOURCES += xrdp_accel_assist_nvenc.c xrdp_accel_assist_nvenc.h encoder_headers/nvEncodeAPI_11_1.h | ||
endif | ||
|
||
pkglibexec_PROGRAMS = \ | ||
xrdp-accel-assist | ||
|
||
xrdp_accel_assist_SOURCES = \ | ||
xrdp_accel_assist.c \ | ||
xrdp_accel_assist.h \ | ||
xrdp_accel_assist_x11.c \ | ||
xrdp_accel_assist_x11.h \ | ||
xrdp_accel_assist_egl.c \ | ||
xrdp_accel_assist_egl.h \ | ||
xrdp_accel_assist_glx.c \ | ||
xrdp_accel_assist_glx.h \ | ||
$(XRDP_EXTRA_SOURCES) | ||
|
||
xrdp_accel_assist_LDADD = \ | ||
$(top_builddir)/common/libcommon.la \ | ||
$(XRDP_EXTRA_LIBS) \ | ||
-lX11 -lepoxy | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding error logging if this doesn't work, for triaging user issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't t think the log ing system is initialized at this point. Can we still log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're quite right. Calling
LOG()
won't work.Two possible solutions:-
stderr
in this function. This isn't ideal, but it will at least get picked up by the journal on systemd-based systems.g_cu_init()
?) called explicitly from sesman after logging has started. We can remove it if you ever get a better answer as to why this function is required.