NTRN-323 Feat: Add dex pause dao logic #106
Conversation
jcompagni10
force-pushed
the
feat/add-dex-pause
branch
from
bbb93d0 to
758a610
Compare
jcompagni10
changed the title
|
Please attach a successful testrun |
| .ok_or(ContractError::Unauthorized {})?; | ||
|
|
||
| let dex_params = get_dex_params(deps, ParamsRequestDex {})?; | ||
| // TODO: do this through iteration instead of ifs for future proofing new params |
There was a problem hiding this comment.
please resolve it somehow
There was a problem hiding this comment.
As written in TODO, I don't like it since we will need to upgrade the contract with changes to params of dex. And because it's not an instant process, it's gonna be a pain.
I would suggest the following.
Convert dex_params to slice of (string, string) values as well as msg_update_params, assign it the pause param from the message, and then check that all fields exactly match.
WDYT? Not sure if it's easy
There was a problem hiding this comment.
I agree it's a bit annoying. But as far as I know, there is no easy way to iterate through a rust struct with arbitrary keys. We could do this by marshalling with serde but it starts to get pretty ugly.
Also, if new dex params are added we would still have to update the contract to change the allow strategies and struct for retrieving dex params. So I don't think it's terrible
Allow dao to change permissions for the dex.
Related PRs:
neutron-org/neutronjsplus#41
https://github.com/neutron-org/neutron-integration-tests/pull/313/files
Integration test run
https://github.com/neutron-org/neutron-tests/actions/runs/10012028532