feat: fee payer #45

ratik · 2023-01-23T12:36:13Z

related stuff:

pr0n00gler · 2023-01-24T09:30:15Z

docs/neutron/feerefunder/overview.md

@@ -21,10 +21,29 @@ The module requires smart-contracts, which use [Transfer](../transfer/messages#m
 * `ack_fee` - amount of coins to refund relayer for submittting ack message for a particular IBC packet (i.e. `500untrn`);
 * `timeout_fee` - amount of coins to refund relayer for submitting timeout message for a particular IBC packet (i.e. `500untrn`);
 * `recv_fee` - currently is used for compatibility with ICS-29 interface only and **must be set to zero** (i.e. `0untrn`), because Neutron's fee module can't refund relayers for submission of `Recv` IBC packets due to compatibility with target chains.
+* `payer` - optional address of the contract which will pay for the fees. Please note that payer must give allowance to the contract to spend fees.


optional address of the contract

looks a bit weird

pr0n00gler · 2023-01-24T09:32:30Z

docs/neutron/feerefunder/state.md

@@ -2,7 +2,7 @@

 The FeeRefunder module stores one [FeeInfo](https://github.com/neutron-org/neutron/blob/a9e8ba5ebb9230bec97a4f2826d75a4e0e6130d9/proto/feerefunder/genesis.proto#L18) per [`channel_id`, `port_id` and `sequence`](https://github.com/neutron-org/neutron/blob/a9e8ba5ebb9230bec97a4f2826d75a4e0e6130d9/x/feerefunder/types/keys.go#L28).
 `FeeInfo` contains all the necessary info to store data about fees to properly refund relayers and return fees to the original caller of IBC messages:
-* `payer` - stores an address of the smart-contract which issues `Transfer` or `SubmitTx` message;
+* `payer` - stores an address of the smart-contract (or fee payer) which issues `Transfer` or `SubmitTx` message;


Looks a bit weird now, cause fee payer doesn't issue Transfer or SubmitTx messages

pr0n00gler · 2023-01-24T09:32:44Z

docs/neutron/feerefunder/overview.md

+
+    2. The fee payer can grant an allowance to a contract address, which allows the contract to use tokens from this address for the fees. Optionally, a limit, expire date, and period can be set, please refer to the [feegrant module's documentation in the Cosmos SDK](https://docs.cosmos.network/v0.46/modules/feegrant/) for more information.
+
+    3. When an interchain transaction is requested by a contract, the feerefunder module checks the allowance in general by using the feegrant module's GetAllowance function.


or transfer message

docs/neutron/feerefunder/overview.md

NeverHappened · 2023-01-25T08:41:45Z

docs/neutron/feerefunder/state.md

@@ -2,7 +2,7 @@

 The FeeRefunder module stores one [FeeInfo](https://github.com/neutron-org/neutron/blob/a9e8ba5ebb9230bec97a4f2826d75a4e0e6130d9/proto/feerefunder/genesis.proto#L18) per [`channel_id`, `port_id` and `sequence`](https://github.com/neutron-org/neutron/blob/a9e8ba5ebb9230bec97a4f2826d75a4e0e6130d9/x/feerefunder/types/keys.go#L28).
 `FeeInfo` contains all the necessary info to store data about fees to properly refund relayers and return fees to the original caller of IBC messages:
-* `payer` - stores an address of the smart-contract which issues `Transfer` or `SubmitTx` message;
+* `payer` - stores an address of the smart-contract (or fee payer) which will be refunded after the IBC packet is processed;


maybe stores the fee payer address (smart contract or other fee payer) which will be refunded after the IBC packet is processed?

docs/neutron/feerefunder/overview.md

sotnikov-s · 2023-01-26T12:18:23Z

docs/neutron/feerefunder/client.md

@@ -53,5 +53,6 @@ Output:
          timeout_fee:
            - denom: "untrn"
              amount: "500"
+        payer: neutron10h9stc5v6ntgeygf5xf945njqq5h32r54rf7kf


please fix the fee-info command description above:

sotnikov-s · 2023-01-26T12:20:01Z

docs/neutron/feerefunder/overview.md

@@ -21,10 +21,29 @@ The module requires smart-contracts, which use [Transfer](../transfer/messages#m
 * `ack_fee` - amount of coins to refund relayer for submittting ack message for a particular IBC packet (i.e. `500untrn`);
 * `timeout_fee` - amount of coins to refund relayer for submitting timeout message for a particular IBC packet (i.e. `500untrn`);
 * `recv_fee` - currently is used for compatibility with ICS-29 interface only and **must be set to zero** (i.e. `0untrn`), because Neutron's fee module can't refund relayers for submission of `Recv` IBC packets due to compatibility with target chains.
+* `payer` - optional address which will pay for the fees. Please note that payer must give allowance to the contract to spend fees.


to have a link to the relative feegrant doc page will be very handy here. or a link to the Details on Fee Payer section

sotnikov-s · 2023-01-26T12:24:01Z

docs/neutron/feerefunder/overview.md


 > **Note:** the fees can be specified only in native Cosmos-SDK coins. CW-20 coins are not supported!

-When a smart-contract issues `Transfer` or `SubmitTx` message, the fee Module deduct the whole specified fee amount (`ack_fee + timeout_fee + recv_fee`) and locks that amount in the module's escrow address. When a relayer submits `Ack` message for a particular packet, the module sends the specified amount of `ack_fee` to the relayer from the escrow address and return the specified `timeout_fee` to the contract which issued the original `Transfer` or `SubmitTx` message. In case when relayer submits `Timeout` message, things go the other way around: the relayer is refunded with `timeout_fee` and the contract gets `ack_fee` back.
+When a smart-contract issues `Transfer` or `SubmitTx` message, the fee Module deduct the whole specified fee amount (`ack_fee + timeout_fee + recv_fee`) from contract address or from payer address (if it is defined and there is allowance from payer to contract address) and locks that amount in the module's escrow address. When a relayer submits `Ack` message for a particular packet, the module sends the specified amount of `ack_fee` to the relayer from the escrow address and return the specified `timeout_fee` to the contract (or fee payer) which issued the original `Transfer` or `SubmitTx` message. In case when relayer submits `Timeout` message, things go the other way around: the relayer is refunded with `timeout_fee` and the contract gets `ack_fee` back.


please correct:

message, the fee Module (1) deduct (2) the whole:

the FeeRefunder Module

deducts

the relayer is refunded with timeout_fee and the contract (1) gets ack_fee back

and the contract (or fee payer)

ratik mentioned this pull request Jan 23, 2023

feat: feePayer for Sudo fees neutron-org/neutron#129

Closed

ratik force-pushed the feat/NTRN-331-sudo-fees-payer branch 2 times, most recently from e4238b9 to edae216 Compare January 23, 2023 12:50

feat: fee payer

d0c9936

ratik force-pushed the feat/NTRN-331-sudo-fees-payer branch from edae216 to d0c9936 Compare January 23, 2023 12:51

This was referenced Jan 23, 2023

feat: added fee payer neutron-org/neutron-dev-contracts#6

Open

feat: fee payer added neutron-org/neutron-sdk#77

Open

feat: fee payer for sudo fee neutron-org/neutron-integration-tests#70

Closed

pr0n00gler reviewed Jan 24, 2023

View reviewed changes

fix: review fixes

c168f6d

ratik requested a review from pr0n00gler January 24, 2023 16:21

NeverHappened requested changes Jan 25, 2023

View reviewed changes

chore: clarify and refactor

2e897fa

ratik requested a review from NeverHappened January 26, 2023 12:46

sotnikov-s reviewed Jan 26, 2023

View reviewed changes

ratik added 6 commits January 26, 2023 14:29

fix: block

fcf49fe

chore: trash

44e16b5

chore: remove bold

3169abb

chore: anchor

5b7afe5

fix: links and text typos

2821b33

chore: hack to fix block

6e17e84

sotnikov-s approved these changes Jan 26, 2023

View reviewed changes

NeverHappened approved these changes Jan 27, 2023

View reviewed changes

pr0n00gler approved these changes Jan 29, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fee payer #45

feat: fee payer #45

ratik commented Jan 23, 2023 •

edited

Loading

pr0n00gler Jan 24, 2023

pr0n00gler Jan 24, 2023

pr0n00gler Jan 24, 2023

NeverHappened Jan 25, 2023

sotnikov-s Jan 26, 2023

sotnikov-s Jan 26, 2023

sotnikov-s Jan 26, 2023


		2. The fee payer can grant an allowance to a contract address, which allows the contract to use tokens from this address for the fees. Optionally, a limit, expire date, and period can be set, please refer to the [feegrant module's documentation in the Cosmos SDK](https://docs.cosmos.network/v0.46/modules/feegrant/) for more information.

		3. When an interchain transaction is requested by a contract, the feerefunder module checks the allowance in general by using the feegrant module's GetAllowance function.

feat: fee payer #45

Are you sure you want to change the base?

feat: fee payer #45

Conversation

ratik commented Jan 23, 2023 • edited Loading

pr0n00gler Jan 24, 2023

Choose a reason for hiding this comment

pr0n00gler Jan 24, 2023

Choose a reason for hiding this comment

pr0n00gler Jan 24, 2023

Choose a reason for hiding this comment

NeverHappened Jan 25, 2023

Choose a reason for hiding this comment

sotnikov-s Jan 26, 2023

Choose a reason for hiding this comment

sotnikov-s Jan 26, 2023

Choose a reason for hiding this comment

sotnikov-s Jan 26, 2023

Choose a reason for hiding this comment

ratik commented Jan 23, 2023 •

edited

Loading