Skip to content

Commit

Permalink
Ebpf entity defs: change span.kind to trace_role (#1500)
Browse files Browse the repository at this point in the history
* ebpf entity defs: change span.kind to trace_role

Signed-off-by: Benjamin Kilimnik <[email protected]>

* add quotes around instrumentation provider 'nr_ebpf_agent'

Signed-off-by: Benjamin Kilimnik <[email protected]>

---------

Signed-off-by: Benjamin Kilimnik <[email protected]>
  • Loading branch information
benkilimnik authored Feb 27, 2024
1 parent 735cf8e commit 640c439
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions entity-types/ebpf-client/definition.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ synthesis:
encodeIdentifierInGUID: true
conditions:
- attribute: instrumentation.provider
value: nr_ebpf_agent
- attribute: span.kind
value: "nr_ebpf_agent"
- attribute: trace_role
value: "client"
tags:
local_addr:
Expand Down
2 changes: 1 addition & 1 deletion entity-types/ebpf-client/tests/Span.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"redis.req_cmd": "HMGET",
"instrumentation.provider": "nr_ebpf_agent",
"span.kind": "client",
"trace_role": "client",
"local_addr": "192.xxx.x.xx",
"local_port": "92" ,
"remote_addr": "198.xxx.x.xx",
Expand Down
2 changes: 1 addition & 1 deletion entity-types/ebpf-redis_server/definition.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ synthesis:
present: true
- attribute: instrumentation.provider
value: "nr_ebpf_agent"
- attribute: span.kind
- attribute: trace_role
value: "server"
tags:
local_addr:
Expand Down
2 changes: 1 addition & 1 deletion entity-types/ebpf-redis_server/tests/Span.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"redis.req_cmd": "HMGET",
"instrumentation.provider": "nr_ebpf_agent",
"span.kind": "server",
"trace_role": "server",
"local_addr": "198.xxx.x.xx",
"local_port": "98",
"remote_addr": "192.xxx.x.xx",
Expand Down
4 changes: 2 additions & 2 deletions relationships/synthesis/EBPF-CLIENT-to-EBPF_REDIS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ relationships:
anyOf: [ "Span" ]
- attribute: entity.type
anyOf: [ "REDIS_SERVER" ]
- attribute: span.kind
- attribute: trace_role
value: "server"
relationship:
expires: P75M
Expand All @@ -32,7 +32,7 @@ relationships:
anyOf: [ "Span" ]
- attribute: entity.type
anyOf: [ "EBPF_CLIENT" ]
- attribute: span.kind
- attribute: trace_role
value: "client"
- attribute: redis.req_cmd
present: true
Expand Down

0 comments on commit 640c439

Please sign in to comment.