Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding topic name in tags for relationships for ConfluentCloudKafkaTopic #1863

Merged
merged 26 commits into from
Jan 16, 2025

Conversation

dsankaraganti
Copy link
Contributor

Relevant information

  • Adding topic info to tags as relationship synthesis expects topic available for ConfluentCloudKafkaTopic entity
  • Renaming relationship file as it uses candidate

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

dsankaraganti and others added 25 commits September 24, 2024 20:02
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove the domain from the filename, it was correct before, e.g.

Screenshot 2025-01-16 at 11 32 00

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relationships/synthesis/INFRA-CONFLUENTCLOUDCLUSTER-to-INFRA-CONFLUENTCLOUDKAFKATOPIC.yml

@otaviocarvalho otaviocarvalho merged commit ec71147 into newrelic:main Jan 16, 2025
4 checks passed
rohit-bandlamudi-nr pushed a commit to rohit-bandlamudi-nr/entity-definitions that referenced this pull request Jan 17, 2025
…afkaTopic (newrelic#1863)

* feat: Adding confluent cloud cluster entity

* feat: Adding confluent cloud cluster entity metrics

* feat: NR-258723 dashboard metric query syntax issue fix

* feat: NR-346401 adding new confluent cloud kafka topic entity

* feat: Changed folder name

* Adding  APM entity to ConfluentCloudKafkaTopic entity relationship

* Adding  APM entity to ConfluentCloudKafkaTopic entity relationship

* feat: NR-346406 adding new relationship CONFLUENTCLOUDCLUSTER MANAGES CONFLUENTCLOUDKAFKATOPIC

* feat: NR-346406 using existing category and added new lookup for kafka topic

* feat: Adding tags for confluent kafka topic

* feat: Adding test jsons

* feat: Adding topic name in tags for relationships

* feat: Renaming relationship file

* feat: Revert renaming relationship file

---------

Co-authored-by: Otávio Carvalho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants