Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(config): config/profiles refactor for simplicity #605

Closed
wants to merge 26 commits into from
Closed

chore(config): config/profiles refactor for simplicity #605

wants to merge 26 commits into from

Conversation

ctrombley
Copy link
Contributor

No description provided.

@ctrombley ctrombley self-assigned this Jan 13, 2021
@ctrombley ctrombley changed the title chore(config): config refactor for simplicity chore(config): config/profiles refactor for simplicity Jan 13, 2021
@sanderblue sanderblue force-pushed the chore/config-refactor branch 2 times, most recently from 606ffc6 to a20ab91 Compare January 14, 2021 21:43
ctrombley
ctrombley commented Jan 20, 2021
View reviewed changes
cmd/newrelic/command.go Outdated Show resolved Hide resolved
cmd/newrelic/command.go Outdated Show resolved Hide resolved
cmd/newrelic/command_documentation.go Outdated Show resolved Hide resolved
cmd/newrelic/main.go Outdated Show resolved Hide resolved
internal/apiaccess/command.go Outdated Show resolved Hide resolved
internal/entities/command_tags.go Outdated Show resolved Hide resolved
internal/nerdstorage/command.go Outdated Show resolved Hide resolved
internal/nrql/command.go Outdated Show resolved Hide resolved
internal/profiles/command.go Show resolved Hide resolved
internal/profiles/command.go Show resolved Hide resolved
@ctrombley ctrombley force-pushed the chore/config-refactor branch 3 times, most recently from db88823 to 80dd978 Compare January 21, 2021 05:50
@ctrombley ctrombley marked this pull request as ready for review January 21, 2021 05:56
@ctrombley ctrombley force-pushed the chore/config-refactor branch from 80dd978 to eb2061d Compare January 21, 2021 06:07
zlesnr
zlesnr previously approved these changes Jan 21, 2021
View reviewed changes
ctrombley and others added 19 commits February 1, 2021 08:10
@ctrombley
chore(config): starting configuration refactor
81ca149
@sanderblue @ctrombley
chore(config): continue configuration refactor, add loadDefaultProfil…
4aa6d17 
…e function
@sanderblue @ctrombley
chore(config): set credential values
8098dd2
@sanderblue @ctrombley
chore(config): add set functions for config.json values
5a73553
@ctrombley
chore(config): linting fixes and refactoring
3a1f767
@ctrombley
chore(config): add default profile name getter and setter
4f6d8b5
@ctrombley
chore(config): implement config commands and validation
5c609db
@ctrombley
chore(config): add tests
8ff5b1f
@ctrombley
chore(config): add env var overrides
533409b
@ctrombley
chore(config): integrate new config mechanism throught codebase
aefc803
@sanderblue @ctrombley
chore(config): add validation for ConfigField values
0c70f9d
@sanderblue @ctrombley
chore: fix compilation errors
3bd656a
@sanderblue @ctrombley
chore(config): add findConfigField fn
f2c8f2d
@ctrombley
chore(config): add validationfunc and profile overrides
250dd28
@ctrombley
chore(config): simplify client creation
18e8cb7
@ctrombley
chore(config): implement profile list command
b12626b
@ctrombley
chore(config): shorten new package name
7687915
@ctrombley
chore(config): add profile value validation
de24b47
@ctrombley
chore(config): improve logging during default profile initialization
2468949
@ctrombley ctrombley force-pushed the chore/config-refactor branch from eb2061d to e60f6e5 Compare February 2, 2021 01:59
zlesnr
zlesnr previously approved these changes Feb 3, 2021
View reviewed changes
@ctrombley ctrombley changed the base branch from master to main April 30, 2021 18:47
@ctrombley ctrombley dismissed zlesnr’s stale review April 30, 2021 18:47

The base branch was changed.

Julien4218
Julien4218 requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Julien4218 Julien4218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work is currently been re-done

@ctrombley
Copy link
Contributor Author

Duplicate of #948

@ctrombley ctrombley marked this as a duplicate of #948 Jul 12, 2021
@ctrombley ctrombley closed this Jul 12, 2021
@sanderblue sanderblue deleted the chore/config-refactor branch August 20, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien4218 Julien4218 Julien4218 requested changes

@zlesnr zlesnr zlesnr left review comments

Assignees

@ctrombley ctrombley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctrombley @zlesnr @Julien4218 @sanderblue