Skip to content

Commit

Permalink
Merge pull request #55 from miransar/instrumentation-tags
Browse files Browse the repository at this point in the history
Added instrumentation tags.
  • Loading branch information
asllop authored Jun 6, 2023
2 parents 3c95d87 + 2608314 commit eeecc4a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# CHANGELOG
All notable changes to this project will be documented in this file.

## [3.2.1] - 2023/06/06
### Add
- Instrumentation specific tags

## [3.2.0] - 2023/03/27
### Add
- Domain substitution patterns.
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,9 @@ There is a set of attributes common to all actions sent over a `RokuSystem` and

| Attribute Name | Description |
|---|---|
| `instrumentation.provider` | Always “media”. |
| `instrumentation.name` | Always “roku”. |
| `instrumentation.version` | Agent’s version. |
| `newRelicAgent` | Always “RokuAgent”. |
| `newRelicVersion` | Agent’s version. |
| `sessionId` | Session ID, a hash that is generated every time the Roku app starts. |
Expand Down
5 changes: 5 additions & 0 deletions components/NewRelicAgent/NRAgent.brs
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,11 @@ function nrCreateEvent(eventType as String, actionName as String) as Object
end function

function nrAddAttributes(ev as Object) as Object

'Add default custom attributes for instrumentation'
ev.AddReplace("instrumentation.provider", "media")
ev.AddReplace("instrumentation.name", "roku")
ev.AddReplace("instrumentation.version", m.nrAgentVersion)
ev.AddReplace("newRelicAgent", "RokuAgent")
ev.AddReplace("newRelicVersion", m.nrAgentVersion)
ev.AddReplace("sessionId", m.nrSessionId)
Expand Down
2 changes: 1 addition & 1 deletion components/NewRelicAgent/NRAgent.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<interface>
<!-- Properties -->
<field id="version" type="string" value="3.2.0"/>
<field id="version" type="string" value="3.2.1"/>
<!-- Public Methods (wrapped) -->
<function name="NewRelicInit"/>
<function name="NewRelicVideoStart"/>
Expand Down

0 comments on commit eeecc4a

Please sign in to comment.