refactor(routes): Remove parentId parameter from page routes
#948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
refactor/page_routes
branch
3 times, most recently
from
935449d to
ec81a64
Compare
juliusknorr
approved these changes
Oct 23, 2023
The `parentId` has been been superfluous information all the time for all routes except "create new page". If we need the parent, it's better to retrieve it from the `pageId` instead of trusting the client that they passed the right `parentId`. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
refactor/page_routes
branch
from
ec81a64 to
4ad8293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parentIdhas been been superfluous information all the time for all routes except "create new page". If we need the parent, it's better to retrieve it from thepageIdinstead of trusting the client that they passed the rightparentId.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)