-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: use PUT/PATCH for updating and move to API v2.2 #1809
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
=========================================
Coverage 43.96% 43.96%
Complexity 646 646
=========================================
Files 58 58
Lines 2550 2550
=========================================
Hits 1121 1121
Misses 1429 1429 |
Signed-off-by: Christian Hartmann <[email protected]>
66cb437
to
c84e09d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, two comments but overall 🧹
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Chartman123 <[email protected]>
You were a little bit too quick with merging... I wanted to rebase this again and have the two commits in one ;) |
This fixes #1464 by adding new PUT/PATCH routes for current POST routes that update data.
Additionally, this changes the API level to v2.2 and marks the POST endpoints as deprecated. The will be removed in v3 of the API as a breaking change.
Changes:
Explication:
Signed-off-by: Christian Hartmann [email protected]