Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Add Forms to header title on public link view #1828

Merged
merged 1 commit into from
Dec 12, 2023
Merged

enh: Add Forms to header title on public link view #1828

merged 1 commit into from
Dec 12, 2023

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Dec 11, 2023 •
edited
Loading

This fixes #1752

grafik

Signed-off-by: Christian Hartmann [email protected]

@Chartman123 Chartman123 added the enhancement New feature or request label Dec 11, 2023
@Chartman123 Chartman123 self-assigned this Dec 11, 2023
@Chartman123 Chartman123 added the php PHP related ticket label Dec 11, 2023
@Chartman123 Chartman123 added the design Related to the design label Dec 11, 2023
@Chartman123 Chartman123 added this to the 4.0 milestone Dec 11, 2023
@Chartman123 Chartman123 requested a review from susnux December 11, 2023 18:43
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Dec 11, 2023
@Chartman123
Copy link
Collaborator Author

/backport to stable3

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 11, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Merging #1828 (601becf) into main (d23e0d7) will increase coverage by 0.19%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1828      +/-   ##
============================================
+ Coverage     44.73%   44.92%   +0.19%     
  Complexity      649      649              
============================================
  Files            58       58              
  Lines          2555     2544      -11     
============================================
  Hits           1143     1143              
+ Misses         1412     1401      -11

jancborchardt
jancborchardt approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice. :)

@Chartman123 Chartman123 merged commit d2878a4 into main Dec 12, 2023
43 of 44 checks passed
@Chartman123 Chartman123 deleted the enh/add-forms-to-public-title branch December 12, 2023 09:23
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 12, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Chartman123 Chartman123

Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request php PHP related ticket
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Form Page Header Title
2 participants
@Chartman123 @jancborchardt