Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to reorder options for "multiple" question type in backend #2333

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Chartman123
Copy link
Collaborator

This uses backend part of the original PR #2092 by @susnux to include it in the 4.3 release. The frontend still needs some more love and will be part of 5.0

@Chartman123 Chartman123 marked this pull request as draft September 23, 2024 16:12
@Chartman123 Chartman123 added 2. developing Work in progress enhancement New feature or request php PHP related ticket feature: 📑 form creation labels Sep 23, 2024
@Chartman123 Chartman123 added this to the 4.3 milestone Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 80 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@683a519). Learn more about missing BASE report.
Report is 168 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2333   +/-   ##
=======================================
  Coverage        ?   35.62%           
  Complexity      ?     1028           
=======================================
  Files           ?       71           
  Lines           ?     3882           
  Branches        ?        0           
=======================================
  Hits            ?     1383           
  Misses          ?     2499           
  Partials        ?        0           

@Chartman123 Chartman123 force-pushed the feat/reorder-options-backend branch from b029248 to 45c396b Compare September 23, 2024 22:46
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 23, 2024
@Chartman123 Chartman123 marked this pull request as ready for review September 23, 2024 22:47
@Chartman123 Chartman123 requested review from susnux and Koc September 23, 2024 22:47
@Chartman123
Copy link
Collaborator Author

First part for closing #354

@Chartman123 Chartman123 mentioned this pull request Sep 23, 2024
5 tasks
@Chartman123 Chartman123 force-pushed the feat/reorder-options-backend branch 5 times, most recently from 10ddcbd to 2ce5993 Compare September 27, 2024 21:10
@Chartman123
Copy link
Collaborator Author

@Koc @susnux I think this is ready now, please review :) I would then create a new release 4.3 :)

@Chartman123 Chartman123 force-pushed the feat/reorder-options-backend branch 2 times, most recently from 04783ca to ddeeb85 Compare September 29, 2024 20:31
@Chartman123 Chartman123 requested a review from hamza221 October 2, 2024 09:02
@Chartman123 Chartman123 force-pushed the feat/reorder-options-backend branch from ddeeb85 to c1acdcf Compare October 2, 2024 09:03
@hamza221
Copy link
Contributor

hamza221 commented Oct 4, 2024

Maybe also a repair step to add order to existing options instead of setting it as NULL ?

@Chartman123
Copy link
Collaborator Author

Maybe also a repair step to add order to existing options instead of setting it as NULL ?

Good idea :) But maybe as a follow up in #2092.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/reorder-options-backend branch from c1acdcf to 7aba08d Compare October 4, 2024 11:18
lib/Controller/ApiController.php Show resolved Hide resolved
@Chartman123 Chartman123 requested a review from hamza221 October 4, 2024 11:27
@Chartman123 Chartman123 merged commit a692d13 into main Oct 4, 2024
50 checks passed
@Chartman123 Chartman123 deleted the feat/reorder-options-backend branch October 4, 2024 11:32
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 📑 form creation feedback-requested php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants