Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Add reuse compliance #2455

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore : Add reuse compliance #2455

merged 1 commit into from
Dec 17, 2024

Conversation

hamza221
Copy link
Contributor

fix #2357

@hamza221 hamza221 added the 3. to review Waiting for reviews label Dec 13, 2024
@hamza221 hamza221 requested a review from Chartman123 December 13, 2024 15:11
@hamza221 hamza221 self-assigned this Dec 13, 2024
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamza221 Thank you very much :)

Please fix the remaining issues regarding prettier and I'm unsure where the failing tests are coming from...

.github/workflows/reuse.yml Show resolved Hide resolved
AUTHORS.md Outdated Show resolved Hide resolved
@hamza221
Copy link
Contributor Author

I'm not sure what's wrong with the unit tests , reuse Job is not reading the reuse.toml for some reason I'll try investigating

@hamza221
Copy link
Contributor Author

blocked by #2466

Signed-off-by: Hamza Mahjoubi <[email protected]>
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.27%. Comparing base (afacbc4) to head (e594064).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2455   +/-   ##
=========================================
  Coverage     44.27%   44.27%           
  Complexity      860      860           
=========================================
  Files            73       73           
  Lines          3268     3268           
=========================================
  Hits           1447     1447           
  Misses         1821     1821           

Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good now :) Thank you very much!

@hamza221 hamza221 merged commit d4623aa into main Dec 17, 2024
53 checks passed
@hamza221 hamza221 deleted the chore/noid/spdx branch December 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: make app REUSE compliant
2 participants