Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable4] fix: Check admin settings when fetching shared forms #2488

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 11, 2025

Backport of #2485

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Chartman123 and susnux January 11, 2025 12:04
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Jan 11, 2025
@backportbot backportbot bot added this to the 4.3.5 milestone Jan 11, 2025
@Chartman123 Chartman123 marked this pull request as ready for review January 11, 2025 14:57
@Chartman123 Chartman123 force-pushed the backport/2485/stable4 branch from fed9923 to c31a259 Compare January 11, 2025 15:37
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable4@c8a082f). Learn more about missing BASE report.
Report is 4 commits behind head on stable4.

Additional details and impacted files
@@            Coverage Diff             @@
##             stable4    #2488   +/-   ##
==========================================
  Coverage           ?   36.67%           
  Complexity         ?     1050           
==========================================
  Files              ?       72           
  Lines              ?     4003           
  Branches           ?        0           
==========================================
  Hits               ?     1468           
  Misses             ?     2535           
  Partials           ?        0           

@susnux susnux force-pushed the backport/2485/stable4 branch from c31a259 to 904d9d7 Compare January 11, 2025 15:53
@Chartman123 Chartman123 merged commit 19a82ca into stable4 Jan 11, 2025
49 checks passed
@Chartman123 Chartman123 deleted the backport/2485/stable4 branch January 11, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants