fix(AppFramework): Log malformed protocol values and unify fallback behavior #50099
+53
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW
android#14306Summary
This PR:
http
at a minimum).We currently:
http
) when a malformed protocol value is received from a reverse proxy (viaX-Forwarded-Proto
).overwriteprotocol
to be reasonable.overwriteprotocol
values (unlikeX-Forwarded-Proto
).The fallback is not a default value. It's just means a reasonable protocol is returned. When the fallback is used, it's basically an error. If it wasn't existing behavior, we might consider throwing an exception here instead. This PR just adds similar fallback behavior for malformed
overwriteprotocol
values and also logs when the fallback is used.Details:
overwriteprotocol
(if any) and when malformed uses same fallback value (http) as we do forX-Forwarded-Proto
HTTP
/HTTPS
) as valid foroverwriteprotocol
(just as it already does forX-Forwarded-Proto
)TODO
Checklist