Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include nac conversion workflow #406

Merged
merged 1 commit into from
Dec 10, 2024
Merged

include nac conversion workflow #406

merged 1 commit into from
Dec 10, 2024

Conversation

fmalmeida
Copy link
Contributor

Hi @grst ,
This is a very quick fix.

When running test_full for testing the PR #404 , I realized it was not working for kallisto nac workflow, because I had forgot to add its file name handlings.

Now adding, so all is handled.

@fmalmeida fmalmeida requested a review from grst December 10, 2024 08:59
Copy link

github-actions bot commented Dec 10, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e00f98c

+| ✅ 214 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.0.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-10 09:01:19

@fmalmeida fmalmeida merged commit 68d2811 into dev Dec 10, 2024
15 checks passed
@fmalmeida fmalmeida deleted the fix-kallisto-nac-in-v300 branch December 10, 2024 10:24
@fmalmeida fmalmeida mentioned this pull request Dec 10, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants