Merge master to develop #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* buildFilter func * WIP * downgrade UserReadService, inject into AdminUserController * explicit add, user-read.service.ts * WIP - UserReadService, replace UserPageingService * [web-app] fix import specifier to resolve typescript compilation error * [web-app] better variable names in post_build script * getAllUsers endpoint api/next-users/search * removed UserReadService * remove left over UserReadService references * UserReadService.search, to incorporate UserPagingService.search functionality in order to deprecate * refactored UserReadService for statelessness, improved search parameters. * fixed recursion issue * fix: Reintroduced 'includeTotalCount' to UserSearchParams for test compatibility * update to user-search-helper.ts file name * PR -fix * fix: Refactor userSearchObservable to prevent state interference. * Adjusted user search function to conditionally send query parameters based on input values. * removed SearchQueryParam from user-read.service * add UserReadService to AdminUserController * remove unused * WIP enabled param * WIP - rest included * active, enabled include only if set * remove UserReadService * calculateLinks * Refactor pagination: Enhance 'move', 'next', and 'previous' in UserPagingService * getAllUser remove comments * Refactor pageIndex logic and optimize total param handling in search * [web-app] restore user read service * Added changeFilter method; Fixed previous button pagination bug * "Fixed 'Next' button functionality for correct page navigation" * current searh term added to userFilter * Refactored performNewSearch to reset pageIndex for new searches * removed duplicate function, search function refactor * [service] fix timestamp bug in observation test --------- Co-authored-by: Robert St. John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge contains the recently merged changes on master to address the admin page user search bug.