Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC stark fixes and extensions #182

Merged
merged 14 commits into from
Oct 4, 2024
Merged

AC stark fixes and extensions #182

merged 14 commits into from
Oct 4, 2024

Conversation

dihm
Copy link
Contributor

@dihm dihm commented Sep 17, 2024

This PR makes a number of changes to ShirleyMethod AC Stark calculations.

  • First, it fixes a few issues in basis generation when q!=0.
  • Makes a few minor corrections in ShirleyMethod.diagonalise that don't change output results, but are more accurate to the underlying physics.
  • A modest speed improvement in calculating transProbs that improves overall diagonalisation times by a small amount.
  • It adds a new method ShirleyMethod.calcTransitionProbability that can calculate the time-dependent transition probabilities, averaged over initial drive phases that model CW drives.
  • There are a number of clarifications and extensions of docstrings and examples to clarify common issues and questions that have come up since initial release.

Fixes #180

dihm and others added 14 commits September 5, 2024 15:42
@dihm
Fixed sign errors in determining dipole allowed transitions in `Stark…
ff3008a 
…BasisGenerator`
@dihm
Ensure that generated basis states are physical in `StarkBasisGenerat…
d886af5 
…or` if `q!=0`
@dihm
Optimize calculation of the long-time average transition probabilities
b03c284 
in `ShirleyMethod`.
@dihm
Add option to manually specify basisStates for StarkBasisGenerator.
be4402f 
This is useful for building simple test models of few-level systems.
@dihm
Allow for basisStates specification to not require specifying un-ne…
92f25ed 
…eded parameters

in `StarkBasisGenerator`
@dihm
Update some docstrings
a294d37
@dihm
Updated example notebook
720acd9
@dihm
Minor tweaks to ShirleyMethod.diagonalise
a15fe22
@dihm
Technical fix to transProbs calculation.
882c0bf 
Moves conjugation to correct term. Does not change results since standard
calcs only have real eigenvalues and eigenvectors anyway.
@dihm
Fix overlap calculation to be only squared, not quartic. Does not change
dd0f17b 
results since only used to index max value which is the same in both cases.
@dihm
Add ShirleyMethod.calcTransitionProbability method.
c08d410 
This allows for calculating the time-dependent transition probability,
assuming a CW drive, averaged over t=0 drive phases.

Simply put, this allows for calculating the actual Rabi flops of the transition
probabilities.
@dihm
Updated example notebook to include CW transition probability calcs
c49f694 
and caution about targetShift calculations.
@dihm
Tidy up the linting
4eb63cf
@dihm
Run new code through black formatting
e4e8fb6
@nikolasibalic nikolasibalic self-requested a review October 4, 2024 14:31
@nikolasibalic nikolasibalic merged commit 2e00f5b into nikolasibalic:master Oct 4, 2024
10 checks passed
@nikolasibalic nikolasibalic added this to the v3.6.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolasibalic nikolasibalic nikolasibalic approved these changes

Assignees

@dihm dihm

Labels
bug feature improvement
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Something wrong in calculations_atom_single.py
2 participants
@dihm @nikolasibalic