Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented compileOption for experimental to test if a feature i… #23933

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Implemented compileOption for experimental to test if a feature i… #23933

merged 1 commit into from
Aug 12, 2024

Conversation

geekrelief
Copy link
Contributor

…s enabled at compile time.

#8644 This doesn't handle the case if {.push experimental.} is used, but at least we can test if a feature was enabled globally.

@Araq
Copy link
Member

Araq commented Aug 11, 2024

The implementation is nice but I'm not sure it's a good idea to offer this feature.

@arnetheduck
Copy link
Contributor

In results, I need a way to know if the new genericsOpenSym experimental is enabled or not and then choose whether to enable a hacky workaround or the native thing - maybe this doesn't apply to all experimentals but it's certainly useful for some of them

@Araq Araq merged commit 20043ea into nim-lang:devel Aug 12, 2024
18 checks passed
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 20043ea

Hint: mm: orc; opt: speed; options: -d:release
173396 lines; 8.247s; 654.758MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants