Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rivermapper tri #170

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Rivermapper tri #170

merged 4 commits into from
Sep 3, 2024

Conversation

felicio93
Copy link
Collaborator

4 new functions added:

  • delaunay_within: Creates the initial delaunay triangulation and select polygons within domain
  • triangulate_shp: calls delaunay_within and fills out any gaps left
  • shptri_to_msht: Converts a triangulated shapefile to msh_t
  • triangulate_rivermapper_poly: main function, takes RiverMapper output and convert to msh_t

Felicio Cassalho and others added 4 commits September 3, 2024 11:05
util functions for triangulating RiverMapper_00
5a72d08
@felicio93
Update utils.py
73f294b
@felicio93
Update functional_test.yml
62cc754 
changed:
actions/upload-artifact@v2

to:
actions/upload-artifact@v4
@felicio93
Update functional_test_2.yml
e223d56 
changed:
actions/upload-artifact@v2

to:
actions/upload-artifact@v4
@felicio93
Copy link
Collaborator Author

@SorooshMani-NOAA, in addition to the util functions added I also had to change the workflow files due to deprecated upload-artifact: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

@felicio93 felicio93 marked this pull request as ready for review September 3, 2024 16:54
@felicio93 felicio93 merged commit 574b8b5 into noaa-ocs-modeling:main Sep 3, 2024
9 checks passed
@felicio93 felicio93 deleted the rivermapper_tri branch September 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felicio93