Updating nexpect to emit events. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows nexpect to work with conditional branching. It will emit 'wait' right now, and the data will be the line of output which matches the expected output. From there, you can re-test the data and call sendline, expect, or wait again. Note that the user MUST call wait BEFORE the end of the stackframe on which the child was spawned.
| "and using the event driven method": { | ||
| "should respond with no error": function () { | ||
| child = nexpect.spawn('node', ['--interactive']); | ||
| child.run(function(err,stdout,exitcode){ |
There was a problem hiding this comment.
This child.run(...) should probably be after the child.on(...) and child.wait(...), but it will work properly in either case as long as they are in the same stack frame.
|
Does anyone else find this change useful? Seems it might finally close #14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows nexpect to work with conditional branching. It will emit
waitright now, and the data will be the line of output which matches the expected output. From there, you can re-test the data and call sendline, expect, or wait again. Note that the user must callwait()before the end of the stackframe in whichrun()was called on the child.This is a rough first draft, but it does not introduce any breaking changes as far as I can tell. All tests still pass, and the new test I have written demonstrates the new functionality. I have also added an example to the readme file.
I think this feature is critical to getting nexpect to actually act like tcl's expect. Otherwise, there is no way that I see to send different input based on the output.