Skip to content

Commit

Permalink
minor changes
Browse files Browse the repository at this point in the history
Signed-off-by: shirady <[email protected]>
  • Loading branch information
shirady committed Jan 14, 2025
1 parent ea9c196 commit 0cef265
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/test/unit_tests/test_s3_bucket_policy.js
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ mocha.describe('s3_bucket_policy', function() {
Bucket: BKT_D,
});
});
const allow_all_principal_all_s3_actions_statement = {
const allow_all_principals_all_s3_actions_statement = {
Sid: `Allow all s3 actions on bucket ${BKT_D} to all principals`,
Effect: 'Allow',
Principal: { AWS: "*" },
Expand All @@ -370,14 +370,14 @@ mocha.describe('s3_bucket_policy', function() {
};

mocha.it('should not allow principal get object bucket policy with 2 statements: ' +
'(1) DENY principal by account ID (2) ALLOW account name as *', async function() {
'(1) DENY principal by account ID (2) ALLOW all principals as *', async function() {
// in NC we allow principal to be also IDs
if (!is_nc_coretest) this.skip(); // eslint-disable-line no-invalid-this
const deny_account_by_id_all_s3_actions_statement =
get_deny_account_by_id_all_s3_actions_statement(user_a_account_details._id);
const policy = {
Statement: [
allow_all_principal_all_s3_actions_statement,
allow_all_principals_all_s3_actions_statement,
deny_account_by_id_all_s3_actions_statement
]
};
Expand Down Expand Up @@ -409,10 +409,10 @@ mocha.describe('s3_bucket_policy', function() {
});

mocha.it('should not allow principal get object bucket policy with 2 statements: ' +
'(1) DENY principal by account name (2) ALLOW account name as *', async function() {
'(1) DENY principal by account name (2) ALLOW all principals as *', async function() {
const policy = {
Statement: [
allow_all_principal_all_s3_actions_statement,
allow_all_principals_all_s3_actions_statement,
deny_account_by_name_all_s3_actions_statement
]
};
Expand Down

0 comments on commit 0cef265

Please sign in to comment.