Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | S3 throwing error for empty header and default port for STS #8579

Merged
merged 1 commit into from
Dec 20, 2024
Merged

NSFS | S3 throwing error for empty header and default port for STS #8579

merged 1 commit into from
Dec 20, 2024

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Dec 5, 2024 •
edited
Loading

Explain the changes

  1. Added check for host header if its missing return empty response
  2. set default port for STS only if its not NC

Issues: Fixed #xxx / Gap #xxx

  1. core.endpoint.sts.sts_rest:: STS ERROR , anonymous account and log4j error messages in s3_rest.js  #8509

Testing Instructions:

  1. Start the NSFS server with: sudo node src/cmd/nsfs
  2. Send S3 request without host header
curl https://localhost:6443 --http1.0 -H 'Host:' --insecure
  1. Request should not return any response
  2. S3 request with host header should return error response
curl https://localhost:6443 --http1.0 --insecure
  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 requested a review from romayalon December 5, 2024 06:50
romayalon
romayalon reviewed Dec 5, 2024
View reviewed changes
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 linked an issue Dec 6, 2024 that may be closed by this pull request
core.endpoint.sts.sts_rest:: STS ERROR , anonymous account and log4j error messages in s3_rest.js #8509
Closed
shirady
shirady reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments

config.js Show resolved Hide resolved
src/endpoint/endpoint.js Show resolved Hide resolved
src/endpoint/s3/s3_rest.js Outdated Show resolved Hide resolved
src/endpoint/s3/s3_rest.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 force-pushed the nsfs_error_messages branch 2 times, most recently from cd9ae64 to 2d522de Compare December 17, 2024 04:57
shirady
shirady reviewed Dec 17, 2024
View reviewed changes
src/endpoint/s3/s3_rest.js Show resolved Hide resolved
src/endpoint/s3/s3_rest.js Show resolved Hide resolved
romayalon
romayalon approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naveenpaul1 Can you pls check if we need to fix the missing hostname header on STS and IAM as well? or at least open an issue

@naveenpaul1
Copy link
Contributor Author

@romayalon new issue opened: #8617

@naveenpaul1 naveenpaul1 merged commit 2b3f925 into noobaa:master Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirady shirady shirady left review comments

@romayalon romayalon romayalon approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core.endpoint.sts.sts_rest:: STS ERROR , anonymous account and log4j error messages in s3_rest.js
3 participants
@naveenpaul1 @romayalon @shirady