Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket notification - ensure all lines in a persitent log are processed (gh issue 8653) #8662

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. Wrap a single line of the notification persistent log in a try/catch.
    If a single line fails, we will still process the rest of the file.

Issues: Fixed #xxx / Gap #xxx

  1. If connection fails for the first few events it fails for others as well in the events.log file #8653

Testing Instructions:

  1. Create two notifications.
  2. Change the name of the connection of the first notification in the log file to a non-existing connection file.
  3. Run notification nsfs cli
  4. The first notification goes on to a failure notification log. The second notification is sent.
  • Doc added/updated
  • Tests added

@alphaprinz alphaprinz merged commit 038ce84 into noobaa:master Jan 8, 2025
11 checks passed
nimrod-becker pushed a commit to nimrod-becker/noobaa-core that referenced this pull request Jan 13, 2025
…ed (gh issue 8653) (noobaa#8662)

Signed-off-by: Amit Prinz Setter <[email protected]>
(cherry picked from commit 038ce84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants