Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Online Upgrade | Integration tests | Add CLI and S3 integration tests #8682

Merged

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Jan 13, 2025

Explain the changes

  1. Added integration tests for CLI and S3 commands during a mocked online upgrade (before the upgrade finished).
  2. These tests assert that -
    • config directory updates are not allowed via the CLI nor via S3.
    • S3 Objects operations are allowed.
    • CLI list/status commands are allowed.

Testing Instructions:

  1. online upgrade + manage CLI integration tests - sudo jest --testRegex=jest_tests/test_nc_online_upgrade_cli_integrations
  2. online upgrade + S3 operations - sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nc_online_upgrade_s3_integrations.js
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-online-upgrade-integration-tests branch from 3a897ec to 2b2e81b Compare January 13, 2025 16:33
@romayalon romayalon requested a review from shirady January 13, 2025 16:34
@romayalon romayalon force-pushed the romy-online-upgrade-integration-tests branch from 2b2e81b to 995b819 Compare January 16, 2025 07:49
@romayalon romayalon requested a review from naveenpaul1 January 16, 2025 07:49
@romayalon romayalon force-pushed the romy-online-upgrade-integration-tests branch from dd62007 to e6354aa Compare January 16, 2025 09:05
@romayalon romayalon force-pushed the romy-online-upgrade-integration-tests branch from e6354aa to 19a16d6 Compare January 16, 2025 13:56
@romayalon romayalon merged commit 49ad768 into noobaa:master Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants