bucket notification - introduce batch param #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspandey
reviewed
Jan 15, 2025
Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz
force-pushed
the
notif_batch
branch
from
f6e9b43 to
5ce6260
Compare
aspandey
reviewed
Jan 15, 2025
| this.name = name; | ||
| this.connect_str_to_connection = new Map(); | ||
| this.notif_to_connect = new Map(); | ||
| this.fs_context = fs_context ?? get_process_fs_context(); | ||
| this.connect_files_dir = connect_files_dir ?? DEFAULT_CONNECT_FILES_DIR; | ||
| this.nc_config_fs = nc_config_fs; | ||
| this.batch_size = batch_size || config.NOTIFICATION_BATCH || 10; |
There was a problem hiding this comment.
I thought you will obviously remove it so I did not give comment on this.
Here now you can remove 10. right?
There was a problem hiding this comment.
Might be over-protective in practice.
In theory someone might nullify config.NOTIFICATION_BATCH.
aspandey
approved these changes
Jan 15, 2025
alphaprinz
added a commit
to alphaprinz/noobaa-core
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Amit Prinz Setter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This fix sends notifications in batches to avoid too many inflight requests.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: