Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application: sdp: mspi: Ipc Hrt Connection #19449

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mif1-nordic
Copy link

@mif1-nordic mif1-nordic commented Dec 11, 2024

Depends on patch #18893

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 11, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 11, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 45

Inputs:

Sources:

sdk-nrf: PR head: 99ecfc42d469c77792a7064f5581035816a0ed23

more details

sdk-nrf:

PR head: 99ecfc42d469c77792a7064f5581035816a0ed23
merge base: a14701baea486b7d65771ad3b9826719c60633dd
target head (main): 020cc3fe3ac6adc8f2a26972768a8a594b19a8c4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuflpr.conf
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt.c
│  │  │  │  │  ├── hrt.h
│  │  │  │  │  │ hrt.s
│  │  │  │  │ main.c
cmake
│  │ sdp.cmake
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ❌ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-sidewalk
    • ❌ test-sdk-wifi
    • ❌ test-low-level
    • ❌ test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps
    • ✅ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@mif1-nordic mif1-nordic force-pushed the HRT_Config branch 5 times, most recently from 4a5d77c to c2b4727 Compare December 16, 2024 09:27
@mif1-nordic mif1-nordic marked this pull request as ready for review December 16, 2024 09:52
@mif1-nordic mif1-nordic requested review from a team as code owners December 16, 2024 09:52
Copy link
Contributor

@magp-nordic magp-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit needs a description and a sign-off (I do not see it right know). Also, it should probably be divided into more commits based on directory that you're changing (with exception to changes in drivers and include/drivers, they can be in the same commit).

applications/sdp/mspi/CMakeLists.txt Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Show resolved Hide resolved
snippets/sdp/mspi/flpr.conf Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
include/drivers/mspi/nrfe_mspi.h Outdated Show resolved Hide resolved
snippets/sdp/mspi/soc/nrf54l15_cpuapp.overlay Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
@nrfconnect nrfconnect deleted a comment from masz-nordic Dec 17, 2024
@nrfconnect nrfconnect deleted a comment from masz-nordic Dec 17, 2024
@nrfconnect nrfconnect deleted a comment from jaz1-nordic Dec 17, 2024
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
Copy link
Contributor

@magp-nordic magp-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. There are still variables that could be named better and things that could be improved, but I won't block it.

drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
@masz-nordic masz-nordic added this to the 3.0.0 milestone Jan 14, 2025
@mif1-nordic mif1-nordic force-pushed the HRT_Config branch 2 times, most recently from 48277cb to b350d8f Compare January 15, 2025 12:37
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed manifest labels Jan 15, 2025
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@mif1-nordic mif1-nordic force-pushed the HRT_Config branch 5 times, most recently from 38b4f32 to 20498de Compare January 15, 2025 14:47
Copy link
Contributor

@jaz1-nordic jaz1-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit picks. And still clang failures.

applications/sdp/mspi/src/hrt/hrt.c Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the HRT_Config branch 2 times, most recently from ca1f61b to 57c9d5f Compare January 15, 2025 15:29
@tejlmand
Copy link
Contributor

@mif1-nordic The first 3 commits in this PR is identical to #19877.

When creating multiple PRs which contains identical commits, then please make it very clear which commits should be reviewed in which PR, and in the PR where they shouldn't be reviewed, then squash those commits and make a commit message like:

Do not review here, please review in PR #19877

@mif1-nordic mif1-nordic force-pushed the HRT_Config branch 2 times, most recently from d0415b5 to e69d801 Compare January 16, 2025 11:25
kobj-types-enum.h was generated after VPR
asm_gen, moved asm_gen to POST_BUILD.

Signed-off-by: Michal Frankiewicz <[email protected]>
jaz1-nordic and others added 2 commits January 16, 2025 15:50
added mode support for SINGLE,QUAD,QUAD_1_4_4,QUAD_1_1_4
and custom Ipc mspi structures

Signed-off-by: Michal Frankiewicz <[email protected]>
Signed-off-by: Jakub Zymelka <[email protected]>
Added reactions to all mspi Ipc messages but
NRFE_MSPI_TXRX and NRFE_MSPI_TX. The data is stored
in local structures for later use.

Signed-off-by: Michal Frankiewicz <[email protected]>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 16, 2025

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zrelease[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 512[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)
sample.matter.template.debug[nrf52840dk/nrf52840]: ROM size increased by 2932[B] in comparison to the main[874962f] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug.uart[nrf54h20dk/nrf54h20/cpuapp]: RAM size increased by 816[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.uart[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 608[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)
sample.matter.template.release[nrf52840dk/nrf52840]: ROM size increased by 2872[B] in comparison to the main[874962f] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 820762[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 2936[B] in comparison to the main[874962f] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 2872[B] in comparison to the main[874962f] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 911930[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 512[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek_multicore[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 512[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54h20dk/nrf54h20/cpuapp]: RAM size increased by 816[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 612[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19449/45)

Added MSPI_TX reaction to NRFE_MSPI_TXRX and NRFE_MSPI_TX.
Added HRT mspi TX functionality.

Signed-off-by: Michal Frankiewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants