-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application: sdp: mspi: Ipc Hrt Connection #19449
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 99ecfc42d469c77792a7064f5581035816a0ed23 more detailssdk-nrf:
Github labels
List of changed files detected by CI (8)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
4a5d77c
to
c2b4727
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit needs a description and a sign-off (I do not see it right know). Also, it should probably be divided into more commits based on directory that you're changing (with exception to changes in drivers
and include/drivers
, they can be in the same commit).
scripts/twister/alt/zephyr/tests/drivers/mspi/api/testcase.yaml
Outdated
Show resolved
Hide resolved
c2b4727
to
8b75e8b
Compare
scripts/twister/alt/zephyr/tests/drivers/mspi/api/testcase.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. There are still variables that could be named better and things that could be improved, but I won't block it.
48277cb
to
b350d8f
Compare
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
38b4f32
to
20498de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit picks. And still clang failures.
ca1f61b
to
57c9d5f
Compare
@mif1-nordic The first 3 commits in this PR is identical to #19877. When creating multiple PRs which contains identical commits, then please make it very clear which commits should be reviewed in which PR, and in the PR where they shouldn't be reviewed, then squash those commits and make a commit message like:
|
d0415b5
to
e69d801
Compare
kobj-types-enum.h was generated after VPR asm_gen, moved asm_gen to POST_BUILD. Signed-off-by: Michal Frankiewicz <[email protected]>
e69d801
to
6319f72
Compare
added mode support for SINGLE,QUAD,QUAD_1_4_4,QUAD_1_1_4 and custom Ipc mspi structures Signed-off-by: Michal Frankiewicz <[email protected]> Signed-off-by: Jakub Zymelka <[email protected]>
Added reactions to all mspi Ipc messages but NRFE_MSPI_TXRX and NRFE_MSPI_TX. The data is stored in local structures for later use. Signed-off-by: Michal Frankiewicz <[email protected]>
6319f72
to
7f5115f
Compare
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zrelease[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 512[B] in comparison to the main[874962f] branch. - link (cc: @MarekPieta) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19449/45) |
Added MSPI_TX reaction to NRFE_MSPI_TXRX and NRFE_MSPI_TX. Added HRT mspi TX functionality. Signed-off-by: Michal Frankiewicz <[email protected]>
7f5115f
to
99ecfc4
Compare
Depends on patch#18893