mgmt: mcumgr: grp: os: Add active b0 slot bootloader info query #19714

nordicjm · 2024-12-30T09:16:15Z

Allows querying the active b0 slot via MCUmgr so that the correct
update image can be loaded to a device

However, FW_INFO is flawed in that it does no image verification at all and just checks the struct, the whole image could have been marked as invalid by b0 and so the application can return the wrong result

NordicBuilder · 2024-12-30T09:17:24Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`1e841e3` (`main`)	nrfconnect/sdk-zephyr#2410	nrfconnect/sdk-zephyr#2410/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-12-30T09:17:46Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 94441a85ac59d36faed74aa98fd7c6951ef727d6
zephyr: PR head: 56c284a8b38e035083807ee501634b73ad1f2b89

more details

sdk-nrf:

PR head: 94441a85ac59d36faed74aa98fd7c6951ef727d6
merge base: 9299b43e0891eb3d300f6139d1b8235f95ed8832
target head (main): 5f476ed09d75635bc98bf78c1aa1114b602ae771
Diff

zephyr:

PR head: 56c284a8b38e035083807ee501634b73ad1f2b89
merge base: 1e841e3e45ad9abf7174d6638e1771a9cc2dd126
target head (main): 52a1ceee359c93ecf0cfeee835b60e7b4c8c78a5
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (14)

cmake
│  ├── sysbuild
│  │  │ b0_mcuboot_signing.cmake
subsys
│  ├── CMakeLists.txt
│  ├── Kconfig
│  ├── mgmt
│  │  ├── mcumgr
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── grp
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── os_mgmt
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ os_mgmt_b0_active_slot.c
sysbuild
│  │ CMakeLists.txt
west.yml
zephyr
│  ├── include
│  │  ├── zephyr
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── grp
│  │  │  │  │  │  ├── os_mgmt
│  │  │  │  │  │  │  │ os_mgmt.h
│  ├── subsys
│  │  ├── mgmt
│  │  │  ├── mcumgr
│  │  │  │  ├── grp
│  │  │  │  │  ├── os_mgmt
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ os_mgmt.c

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
❌ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
- ❌ test_ble_nrf_config
- ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-secdom-samples-public
- ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-12-30T09:36:35Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

philips77 · 2025-01-08T11:56:16Z

subsys/mgmt/mcumgr/grp/os_mgmt/src/os_mgmt_b0_active_slot.c

+		return MGMT_CB_ERROR_RC;
+	}
+
+	/* If no parameter is recognized then just introduce the bootloader. */


This comment seems copy-pasted.

Comment removed

This can be used by the application to know if MCUboot and b0 are enabled, though the slot itself cannot be used from the application Signed-off-by: Jamie McCrae <[email protected]>

Includes an update to add a new MCUmgr OS group error code Signed-off-by: Jamie McCrae <[email protected]>

Allows querying the active b0 slot via MCUmgr so that the correct update image can be loaded to a device Signed-off-by: Jamie McCrae <[email protected]>

Adds slot numbers to the manifest used when building MCUboot updates for b0 Signed-off-by: Jamie McCrae <[email protected]>

NordicBuilder · 2025-01-09T16:17:08Z

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 911930[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 820762[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19714/7)

nordicjm requested review from a team as code owners December 30, 2024 09:16

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 30, 2024

nordicjm requested review from nvlsianpu and de-nordic December 30, 2024 09:16

NordicBuilder added manifest-zephyr DNM labels Dec 30, 2024

nordicjm force-pushed the activeb0mcuboot branch from 8f0fa94 to d55e7c9 Compare December 30, 2024 09:19

nordicjm force-pushed the activeb0mcuboot branch from d55e7c9 to 133ff8e Compare December 30, 2024 10:04

philips77 reviewed Jan 8, 2025

View reviewed changes

nordicjm added 4 commits January 9, 2025 14:04

sysbuild: Add MCUboot update ID to application

220cb58

This can be used by the application to know if MCUboot and b0 are enabled, though the slot itself cannot be used from the application Signed-off-by: Jamie McCrae <[email protected]>

manifest: Update sdk-zephyr

04c1696

Includes an update to add a new MCUmgr OS group error code Signed-off-by: Jamie McCrae <[email protected]>

mgmt: mcumgr: grp: os: Add active b0 slot bootloader info query

42ece27

Allows querying the active b0 slot via MCUmgr so that the correct update image can be loaded to a device Signed-off-by: Jamie McCrae <[email protected]>

cmake: sysbuild: b0: Add slot numbers to MCUboot update

94441a8

Adds slot numbers to the manifest used when building MCUboot updates for b0 Signed-off-by: Jamie McCrae <[email protected]>

nordicjm force-pushed the activeb0mcuboot branch from c1a739f to 94441a8 Compare January 9, 2025 14:06

nordicjm requested a review from philips77 January 9, 2025 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgmt: mcumgr: grp: os: Add active b0 slot bootloader info query #19714

mgmt: mcumgr: grp: os: Add active b0 slot bootloader info query #19714

nordicjm commented Dec 30, 2024

NordicBuilder commented Dec 30, 2024 •

edited

Loading

NordicBuilder commented Dec 30, 2024 •

edited

Loading

NordicBuilder commented Dec 30, 2024

philips77 Jan 8, 2025

nordicjm Jan 9, 2025

NordicBuilder commented Jan 9, 2025 •

edited

Loading

mgmt: mcumgr: grp: os: Add active b0 slot bootloader info query #19714

Are you sure you want to change the base?

mgmt: mcumgr: grp: os: Add active b0 slot bootloader info query #19714

Conversation

nordicjm commented Dec 30, 2024

NordicBuilder commented Dec 30, 2024 • edited Loading

NordicBuilder commented Dec 30, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Dec 30, 2024

philips77 Jan 8, 2025

Choose a reason for hiding this comment

nordicjm Jan 9, 2025

Choose a reason for hiding this comment

NordicBuilder commented Jan 9, 2025 • edited Loading

Memory footprint analysis revealed the following potential issues

NordicBuilder commented Dec 30, 2024 •

edited

Loading

NordicBuilder commented Dec 30, 2024 •

edited

Loading

NordicBuilder commented Jan 9, 2025 •

edited

Loading