Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to signing build system #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changes to signing build system #166

wants to merge 2 commits into from

Conversation

ahasztag
Copy link
Collaborator

No description provided.

@NordicBuilder
Copy link
Collaborator

NordicBuilder commented Jan 14, 2025 •
edited
Loading

pytest coverage results

Detailed report:

Type Coverage
lines 85.2% (2041 of 2395 lines)
functions 41.1% (174 of 423 functions)
branches no data found

Note: This message is automatically posted and updated by the CI (latest/test-sdk-dfu/master/317)

@NordicBuilder NordicBuilder mentioned this pull request Jan 14, 2025
Open
adsz-nordic
adsz-nordic reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@adsz-nordic adsz-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor findings to check, some are a probably a matter of preferences.
Please ensure that new files have correct year in a heading.

ncs/Kconfig Outdated Show resolved Hide resolved
suit_generator/suit_encrypt_script_base.py Outdated Show resolved Hide resolved
suit_generator/cmd_encrypt.py Outdated Show resolved Hide resolved
suit_generator/cmd_sign.py Show resolved Hide resolved
suit_generator/cmd_sign.py Show resolved Hide resolved
suit_generator/cmd_sign.py Outdated Show resolved Hide resolved
@ahasztag ahasztag force-pushed the NCSDK-31069_sign_script_build_system branch 3 times, most recently from de2abff to 2afba07 Compare January 16, 2025 07:35
tomchy
tomchy requested changes Jan 16, 2025
View reviewed changes
suit_generator/suit_sign_script_base.py Outdated Show resolved Hide resolved
ncs/basic_kms.py Outdated Show resolved Hide resolved
ncs/encrypt_script.py Outdated Show resolved Hide resolved
ncs/encrypt_script.py Outdated Show resolved Hide resolved
ncs/encrypt_script.py Outdated Show resolved Hide resolved
ncs/encrypt_script.py Outdated Show resolved Hide resolved
ncs/encrypt_script.py Outdated Show resolved Hide resolved
ncs/sign_script.py Outdated Show resolved Hide resolved
suit_generator/suit_encrypt_script_base.py Outdated Show resolved Hide resolved
@ahasztag ahasztag force-pushed the NCSDK-31069_sign_script_build_system branch from 2afba07 to a69847f Compare January 16, 2025 11:00
@ahasztag ahasztag force-pushed the NCSDK-31069_sign_script_build_system branch from a69847f to 2fb17e4 Compare January 16, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszromek-nordic kszromek-nordic kszromek-nordic approved these changes

@adsz-nordic adsz-nordic adsz-nordic approved these changes

@tomchy tomchy tomchy approved these changes

@jnsgsr jnsgsr Awaiting requested review from jnsgsr

@robertstypa robertstypa Awaiting requested review from robertstypa robertstypa is a code owner

@nordic-mik7 nordic-mik7 Awaiting requested review from nordic-mik7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahasztag @NordicBuilder @tomchy @adsz-nordic @kszromek-nordic