-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (cbor2): add pre-check to verify cbor objects to parse #55
Merged
robertstypa
merged 2 commits into
nrfconnect:main
from
robertstypa:fix/NCSDK-24195_memory_error
Nov 15, 2023
Merged
fix (cbor2): add pre-check to verify cbor objects to parse #55
robertstypa
merged 2 commits into
nrfconnect:main
from
robertstypa:fix/NCSDK-24195_memory_error
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest coverage results
Note: This message is automatically posted and updated by the CI (HCS/test-sdk-dfu/master/522) |
robertstypa
force-pushed
the
fix/NCSDK-24195_memory_error
branch
5 times, most recently
from
November 6, 2023 14:38
f1d17f9
to
fb7b7f5
Compare
robertstypa
requested review from
kszromek-nordic and
tomchy
and removed request for
tomchy and
kszromek-nordic
November 6, 2023 14:43
robertstypa
force-pushed
the
fix/NCSDK-24195_memory_error
branch
2 times, most recently
from
November 7, 2023 06:04
810e147
to
dc925d7
Compare
jnsgsr
requested changes
Nov 7, 2023
robertstypa
force-pushed
the
fix/NCSDK-24195_memory_error
branch
from
November 7, 2023 15:22
bb1aefa
to
316633c
Compare
tomchy
approved these changes
Nov 9, 2023
kszromek-nordic
approved these changes
Nov 9, 2023
jnsgsr
approved these changes
Nov 13, 2023
Raise and exception in case requested memory size is higher than parsed object itself Signed-off-by: Robert Stypa <[email protected]>
Signed-off-by: Robert Stypa <[email protected]>
robertstypa
force-pushed
the
fix/NCSDK-24195_memory_error
branch
from
November 15, 2023 06:35
316633c
to
82f64ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an exception in case requested memory size is higher than parsed object itself
Signed-off-by: Robert Stypa [email protected]