Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cbor2): add pre-check to verify cbor objects to parse #55

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

robertstypa
Copy link
Collaborator

@robertstypa robertstypa commented Nov 6, 2023

Raise an exception in case requested memory size is higher than parsed object itself

Signed-off-by: Robert Stypa [email protected]

@NordicBuilder
Copy link
Collaborator

NordicBuilder commented Nov 6, 2023

pytest coverage results

Detailed report:

Type Coverage
lines 95.8% (1615 of 1686 lines)
functions no data found
branches no data found

Note: This message is automatically posted and updated by the CI (HCS/test-sdk-dfu/master/522)

@robertstypa robertstypa force-pushed the fix/NCSDK-24195_memory_error branch 5 times, most recently from f1d17f9 to fb7b7f5 Compare November 6, 2023 14:38
@robertstypa robertstypa requested review from kszromek-nordic and tomchy and removed request for tomchy and kszromek-nordic November 6, 2023 14:43
@robertstypa robertstypa force-pushed the fix/NCSDK-24195_memory_error branch 2 times, most recently from 810e147 to dc925d7 Compare November 7, 2023 06:04
tests/fuzz/fuzz_suit_obj.py Show resolved Hide resolved
suit_generator/suit/types/common.py Show resolved Hide resolved
suit_generator/suit/types/common.py Show resolved Hide resolved
suit_generator/suit/types/common.py Show resolved Hide resolved
suit_generator/suit/types/common.py Show resolved Hide resolved
suit_generator/suit/types/common.py Show resolved Hide resolved
suit_generator/suit/types/common.py Show resolved Hide resolved
suit_generator/cli.py Show resolved Hide resolved
ncs/build.py Show resolved Hide resolved
tests/fuzz/fuzz_suit_tstr.py Show resolved Hide resolved
@robertstypa robertstypa force-pushed the fix/NCSDK-24195_memory_error branch from bb1aefa to 316633c Compare November 7, 2023 15:22
@robertstypa robertstypa requested a review from jnsgsr November 8, 2023 12:34
suit_generator/suit/types/common.py Show resolved Hide resolved
Raise and exception in case requested memory size is higher than parsed object itself

Signed-off-by: Robert Stypa <[email protected]>
@robertstypa robertstypa force-pushed the fix/NCSDK-24195_memory_error branch from 316633c to 82f64ae Compare November 15, 2023 06:35
@robertstypa robertstypa merged commit 6ddd4d8 into nrfconnect:main Nov 15, 2023
1 check passed
@robertstypa robertstypa deleted the fix/NCSDK-24195_memory_error branch February 8, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants