Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block auxiliary clicks #1699

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Block auxiliary clicks #1699

merged 1 commit into from
Sep 15, 2024

Conversation

waldo121
Copy link
Contributor

Fixes #1619

I've decided to block the event application-wide, in case there would be other places the bug would would reproduce.

@nukeop
Copy link
Owner

nukeop commented Sep 13, 2024

Hey, thanks for this fix. I think we'll also need to detect whether it's the middle click, because otherwise it's going to also block right clicks, which are actually used for some functionality (you can search by contextmenu).

@nukeop nukeop merged commit 6ba75e4 into nukeop:master Sep 15, 2024
@waldo121 waldo121 deleted the bug/1619 branch September 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncontrolled middle click behavior.
2 participants