New UI for displaying album with multiple discs on Spotify search result #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for contributing. I see that you've modified the existing tests to take this change into account. Since CI passes, I'm going to merge it now. Thanks again, this covers something we've missed with Spotify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
#1671
In the current UI, multi-CD albums are displayed in a single, continuous track list. Each track from every CD is shown sequentially without any indication of which CD it belongs to, creating potential confusion for the user. Tracks across different CDs are appended in a single list, resulting in duplicate track numbers (e.g. 1st track in both CD 1 and CD 2 are labeled with 1).
New Behavior
@rishiral and I implemented a distinct list for each CD within the album for spotify search result, effectively dividing the album view by CD and ensuring each CD starts from track number 1. UI remained unchanged for album search using other API.
