Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][16.0][IMP] connector extension: refactor export run and minor changes #320

Merged

Conversation

KNVx
Copy link
Contributor

@KNVx KNVx commented Oct 16, 2023

· removed adapters woocommerce and wordpress files
· Binder functions are api.model
· _usage in batch exporter/importer renamed
· wrap_binding is deprecated
· Refactored run

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #320 (f4b4b16) into 16.0 (ae35b3a) will increase coverage by 1.37%.
Report is 2 commits behind head on 16.0.
The diff coverage is 35.00%.

@@            Coverage Diff             @@
##             16.0     #320      +/-   ##
==========================================
+ Coverage   28.17%   29.55%   +1.37%     
==========================================
  Files          42       46       +4     
  Lines        1565     1607      +42     
  Branches      366      360       -6     
==========================================
+ Hits          441      475      +34     
- Misses       1123     1131       +8     
  Partials        1        1              
Files Coverage Δ
connector_extension/components/__init__.py 100.00% <100.00%> (ø)
connector_extension/components/importer.py 36.31% <100.00%> (ø)
connector_extension/components/core.py 70.00% <70.00%> (ø)
connector_extension/components/binder.py 16.96% <20.00%> (+1.00%) ⬆️
connector_extension/common/database.py 46.66% <46.66%> (ø)
connector_extension/components/exporter.py 39.06% <22.91%> (+1.99%) ⬆️

... and 4 files with indirect coverage changes

@KNVx KNVx force-pushed the 16.0-imp-connector_extension-refactor_run_and_minor_changes branch from 6ae40be to aa83af1 Compare October 16, 2023 15:25
@KNVx KNVx changed the title [16.0][IMP] connector extension: refactor export run and minor changes [WIP][16.0][IMP] connector extension: refactor export run and minor changes Oct 16, 2023
@KNVx KNVx force-pushed the 16.0-imp-connector_extension-refactor_run_and_minor_changes branch 6 times, most recently from 2240059 to fa436b6 Compare October 19, 2023 13:26
@KNVx KNVx force-pushed the 16.0-imp-connector_extension-refactor_run_and_minor_changes branch from fa436b6 to f4b4b16 Compare October 19, 2023 14:01
@eantones eantones merged commit 6121549 into 16.0 Oct 19, 2023
6 checks passed
@eantones eantones deleted the 16.0-imp-connector_extension-refactor_run_and_minor_changes branch October 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants