Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input): enhance input attributes #823

Closed
wants to merge 3 commits into from

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Oct 17, 2023

πŸ”— Linked issue

part of #731

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add some native HTML attributes.
I prefer set autocomplete to off but it will make a breaking change, so set to on for now.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Oct 19, 2023 10:49am

Copy link
Member

I'm not sure this is the right way to fix this, we shouldn't have to define all of the props of the <input> element as there are too many: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attributes.

Only props used as part of the component's logic should be defined in my opinion.

@Sma11X
Copy link
Contributor Author

Sma11X commented Oct 19, 2023

I'm not sure this is the right way to fix this, we shouldn't have to define all of the props of the <input> element as there are too many: developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attributes.

I agree. How about keep autocomplete and tabindex these two useful attrs, and update the doc to provide explanations about it ?

Copy link
Member

I'd agree to define the autocomplete and even to set the default to off as personally I spend more time disabling it and never find myself in a situation where I want autocomplete but that's my opinion.

But tabindex is valid on all HTML elements so I don't see why we'd put it on the Input.

@Sma11X
Copy link
Contributor Author

Sma11X commented Oct 20, 2023

I'd agree to define the autocomplete and even to set the default to off as personally I spend more time disabling it and never find myself in a situation where I want autocomplete but that's my opinion.

Or maybe let community to vote for it ?

Copy link
Member

I'd love that but how could we setup a poll?

@Sma11X
Copy link
Contributor Author

Sma11X commented Oct 20, 2023

I'd love that but how could we setup a poll?

If I remember correctly github discussion has the poll option, or maybe vote at discord (might be more users).
BTY the discord link at doc is not available .

@Sma11X
Copy link
Contributor Author

Sma11X commented Oct 24, 2023

I'll close this PR first. There might be another solution.

@Sma11X Sma11X closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants