Fix CMake issue which installed headers incorrectly during conda build #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
bug
AnuradhaKaruppiah
approved these changes
Oct 24, 2024
cwharris
approved these changes
Oct 24, 2024
|
/merge |
rapids-bot
bot
merged commit 7abfdf7
into
nv-morpheus:branch-24.10
16 of 17 checks passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #511 +/- ##
================================================
- Coverage 74.17% 74.15% -0.03%
================================================
Files 407 407
Lines 15049 15049
Branches 1191 1191
================================================
- Hits 11163 11159 -4
- Misses 3886 3890 +4
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Oct 24, 2024
…RC (#1981) Depends on PR nv-morpheus/MRC#511 being completed, merged, and a new conda package uploaded before testing can begin. Fixes a small issue where MRC updated a function to be private to avoid incorrect usage of it. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Christopher Harris (https://github.com/cwharris) URL: #1981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues:
HEADER_SETCloses #509