Address issues in userGuide and keyCommands found when researching markdown translation string extraction #16119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Several issues were discovered with the rendering of the user guide and key commands document in HTML after conversion to markdown.
Key commands document:
There is also a small syntax error in the userGuide, causing the table listing the New Papenmire model braile keys to break in the key commands document. Specifically, the kc beginInclude command appears after the table header rather than before.
Description of user facing changes
the key commands document now renders correctly in HTML.
Description of development approach
_handleSetting
in keyCommandsDoc.py to address the above issues.this also involved correcting level calculation in the
_heading
method. The first heading symbol in t2t is of length 1, but in markdown it is of length 2.Testing strategy:
Viewed English keyCommands.html in a web browser and confirmed that all above issues were corrected.
Known issues with pull request:
None known.
Code Review Checklist: