Upload to build server in publish workflow for nym-vpn-core #1789
+259
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
changed the title
pronebird
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @octol)
octol
force-pushed
the
jon/ci-upload-to-build-server
branch
2 times, most recently
from
81d4f06 to
5fa37ba
Compare
pronebird
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @octol)
nym-vpn-core/crates/nym-dbus/Cargo.toml line 7 at r2 (raw file):
license.workspace = true edition.workspace = true version = "1.2.0-dev"
Should this not be version.workspace = true?
nym-vpn-core/crates/nym-windows/Cargo.toml line 7 at r2 (raw file):
license.workspace = true edition.workspace = true version = "1.2.0-dev"
Same here?
octol
force-pushed
the
jon/ci-upload-to-build-server
branch
from
5fa37ba to
46eedec
Compare
pronebird
approved these changes
Dec 20, 2024
octol
force-pushed
the
jon/ci-upload-to-build-server
branch
2 times, most recently
from
b9bca47 to
15ee3ec
Compare
octol
force-pushed
the
jon/ci-upload-to-build-server
branch
from
29431a9 to
d816503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-devbuildThis change is