Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto crates and fix sphinx issue #94

Merged
merged 9 commits into from
May 7, 2024
Merged

Conversation

simonwicky
Copy link
Contributor

This PR aims to update the crypto crates used and fix a sphinx crypto issue

@simonwicky simonwicky requested a review from jstuczyn April 19, 2024 07:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 93.97590% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 59.02%. Comparing base (ca107d9) to head (2f30cde).

❗ Current head 2f30cde differs from pull request most recent head e9f9aad. Consider uploading reports for the commit e9f9aad to get more accurate results

Files Patch % Lines
src/packet/mod.rs 33.33% 2 Missing ⚠️
src/header/keys.rs 96.15% 1 Missing ⚠️
src/packet/builder.rs 50.00% 1 Missing ⚠️
src/surb/mod.rs 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #94       +/-   ##
============================================
- Coverage    70.63%   59.02%   -11.62%     
============================================
  Files           21       20        -1     
  Lines         2268     2572      +304     
============================================
- Hits          1602     1518       -84     
- Misses         666     1054      +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/crypto/mod.rs Show resolved Hide resolved
src/crypto/mod.rs Outdated Show resolved Hide resolved
src/crypto/mod.rs Show resolved Hide resolved
src/header/mod.rs Outdated Show resolved Hide resolved
src/header/keys.rs Show resolved Hide resolved
@simonwicky simonwicky merged commit 2a2646e into develop May 7, 2024
10 checks passed
@simonwicky simonwicky deleted the simon/x25519 branch May 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants