Add mergeOptions config option (#187)

nytimes · Oct 17, 2022 · 6380e1f · 6380e1f
1 parent 67cde3c
commit 6380e1f
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 3 deletions.
diff --git a/src/__tests__/e2e.test.js b/src/__tests__/e2e.test.js
@@ -50,6 +50,30 @@ describe('e2e', () => {
     expect(dispatchTrackingEvent).toHaveBeenCalledWith({ test: true });
   });
 
+  it('allows tracking errors', () => {
+    @track(null, {
+      mergeOptions: {
+        isMergeableObject: obj => !(obj instanceof Error),
+      },
+    })
+    class TestPage extends React.Component {
+      componentDidMount() {
+        this.props.tracking.trackEvent({ test: new Error('my crazy error') });
+      }
+
+      render() {
+        return 'hi';
+      }
+    }
+
+    mount(<TestPage />);
+
+    expect(dispatchTrackingEvent).toHaveBeenCalledTimes(1);
+    expect(dispatchTrackingEvent).toHaveBeenCalledWith({
+      test: new Error('my crazy error'),
+    });
+  });
+
   it('defaults to dispatchTrackingEvent when no dispatch function passed in to options', () => {
     const testPageData = { page: 'TestPage' };
 

diff --git a/src/useTrackingImpl.js b/src/useTrackingImpl.js
@@ -40,12 +40,23 @@ export default function useTrackingImpl(trackingData, options) {
     return () =>
       contextGetTrackingData === getOwnTrackingData
         ? getOwnTrackingData()
-        : merge(contextGetTrackingData(), getOwnTrackingData());
+        : merge(
+            contextGetTrackingData(),
+            getOwnTrackingData(),
+            (latestOptions.current || {}).mergeOptions
+          );
   }, [getOwnTrackingData, tracking]);
 
   const getTrackingDispatcher = useCallback(() => {
     const contextDispatch = (tracking && tracking.dispatch) || dispatch;
-    return data => contextDispatch(merge(getOwnTrackingData(), data || {}));
+    return data =>
+      contextDispatch(
+        merge(
+          getOwnTrackingData(),
+          data || {},
+          (latestOptions.current || {}).mergeOptions
+        )
+      );
   }, [getOwnTrackingData, tracking, dispatch]);
 
   const trackEvent = useCallback(
@@ -73,7 +84,8 @@ export default function useTrackingImpl(trackingData, options) {
       trackEvent(
         merge(
           contextProcess(getOwnTrackingData()) || {},
-          dispatchOnMount(getTrackingData()) || {}
+          dispatchOnMount(getTrackingData()) || {},
+          (latestOptions.current || {}).mergeOptions
         )
       );
     } else if (typeof contextProcess === 'function') {