minus tweetnacl plus webcrypto #2024
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
pro-wh
force-pushed
the
pro-wh/feature/webcrypto
branch
from
2a13968 to
637ce46
Compare
pro-wh
force-pushed
the
pro-wh/feature/webcrypto
branch
3 times, most recently
from
b1e2eae to
1b14165
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
==========================================
- Coverage 60.63% 59.20% -1.43%
==========================================
Files 130 129 -1
Lines 9604 9592 -12
==========================================
- Hits 5823 5679 -144
- Misses 3781 3913 +132 ☔ View full report in Codecov by Sentry. |
pro-wh
force-pushed
the
pro-wh/feature/webcrypto
branch
2 times, most recently
from
dd234c9 to
765136b
Compare
also split out seedFromMnemonic and privateKeyFromSeed
pro-wh
force-pushed
the
pro-wh/feature/webcrypto
branch
from
765136b to
60ecfae
Compare
|
nah probably don't need to review yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in anticipation of native ed25519 support in browsers