Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labelArrow #702

Closed
wants to merge 1 commit into from
Closed

labelArrow #702

wants to merge 1 commit into from

Conversation

mbostock
Copy link
Member

Fixes #510. TODO:

  • I’m getting a little confused as to whether label and labelArrow are options on scales or axes. For the most part, we only need labels (and arrows) on axes. But, labels are also used for legends. So, I probably shouldn’t only implement labelArrow on axes, as we will probably also want them on legends. But (color) legends are always oriented left-right, and we don’t support labels on all legends (related labels for swatches #621).

This isn’t a high priority so I’m just going to let this sit. I thought it would be easier. 🙁

@Fil Fil mentioned this pull request Jan 29, 2022
Merged
@mbostock
Copy link
Member Author

This might want to be incorporated into #1197.

@mbostock mbostock mentioned this pull request May 16, 2023
Merged
@mbostock
Copy link
Member Author

Superseded by #1566.

@mbostock mbostock closed this May 16, 2023
@mbostock mbostock deleted the mbostock/labelArrow branch May 16, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Axis label helper?
1 participant
@mbostock