Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach from the one I took previously to adding the "array reinterpret" operations, e.g. given an
int64# array
, get the two values corresponding to the type#(float# * float#)
from byte offset 8 (which is unaligned with respect to the product type as a whole). I think this way is easier: the Lambda primitives now mirror what happens in the middle end, namely they take both the array kind and the array ref/set kind. (This means that all this information basically just passes throughLambda_to_flambda
, which in fact could now become simpler, as some conversion functions could now be deleted were it not for the float array optimization.)We should be able to expose reinterpret primitives in
Translprim
which map to these existing primitives, just with the kinds appropriately set, I hope.