Grouping symbols for closures and code, and closure projection substitution #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2021
Keryan-dev
force-pushed
the
symbol-grouping
branch
from
951fcf7 to
ec76f80
Compare
|
Being done in the Flambda backend repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(From #571, relevant diff)
This finish the job of #511 by replacing closure projections by the corresponding lifted symbols and grouping the symbols in a single let-binding.
This is concurrent to #540, which orders declarations and groups them in a much less lowbrow manner.
The patch is not in a mergeable state, see issue #542.