-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Lin package #164
Split Lin package #164
Conversation
I've now taken a pass over this PR. A few things I noticed - only related to naming really:
|
6a78c51
to
4c9b002
Compare
I rebased (well, largely rewritten) this PR on I do agree with your naming remarks, so I did revert the changes I had made. I suggest we do rename (to Last point that requires work (maybe in a further PR also?) is |
It also does not yet update the documentation, but I suggest we do this also in a separate PR. Since this one is modifying so many source files in our test suite, we would avoid a lot of conflicts by merging soon. |
4c9b002
to
45f27f0
Compare
This commit only moves lines into their respective new modules so that it is possible to check that it does no other refactoring. Thus it obviously does not build Bisection: skip
Add a Lin_base module, as the entrypoint of the qcheck-lin.base library
45f27f0
to
fd1e200
Compare
And rebased on |
Thanks a bunch for this 🙏 |
Refactor the Lin package into sub-libraries so that users can choose to use only the domain, the thread or the effect implementation. That way it is possible to test the domain and effect implementation in runs without running first the thread initialisation code.
Put the part of the interface that should not be used by external users into
_internal
modules. They can’t be really hidden (by using duneprivate_modules
stanza for instance) without breaking the test suite.This PR is really only about the couple of commits at the tip of that branch. They are currently based off an integration branch because it is meant to be merged when #112 will have been merged.